Memory implementation incorrect but passes test script

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Memory implementation incorrect but passes test script

kaganovich
I think the Memory test script has a problem.
If I implement Memory.hdl like this:

        RAM16K(in=in,load=load,address[0..13]=address[0..13],out=ramOut);
        Screen(in=in,load=load,address=address[0..12],out=screenOut);
        Keyboard(out=kbdOut);
        Mux4Way16(a=ramOut,b=ramOut,c=screenOut,d=kbdOut,sel=address[13..14],out=out);

The test script will pass, but it is posible in case load==1 that the Screen and the RAM will be effected undesirably.
Am I right?
Reply | Threaded
Open this post in threaded view
|

Re: Memory implementation incorrect but passes test script

cadet1620
Administrator
See this post for Memory test files that do more detailed testing and detect addressing and cross-read/write problems.

--Mark